codecov-commenter
commented
4 years ago Codecov Report
Merging #323 into master will decrease coverage by
0.41%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 92.48% 92.06% -0.42%
==========================================
Files 71 66 -5
Lines 2394 2295 -99
==========================================
- Hits 2214 2113 -101
- Misses 180 182 +2 | Impacted Files | Coverage Δ | |
|---|---|---|
| busy_beaver/apps/slack_integration/models.py | 100.00% <ø> (ø) |
|
| busy_beaver/blueprints.py | 100.00% <ø> (ø) |
|
| busy_beaver/common/models.py | 100.00% <ø> (ø) |
|
| busy_beaver/common/wrappers/__init__.py | 100.00% <ø> (ø) |
|
| busy_beaver/config.py | 100.00% <ø> (ø) |
|
| busy_beaver/app.py | 98.00% <100.00%> (-0.04%) |
:arrow_down: |
| busy_beaver/clients.py | 100.00% <100.00%> (ø) |
|
| busy_beaver/models.py | 100.00% <100.00%> (ø) |
|
| busy_beaver/apps/web/views.py | 77.59% <0.00%> (-0.19%) |
:arrow_down: |
| busy_beaver/apps/web/forms.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0adeae3...3801c50. Read the comment docs.
What does this do
Removing the retweeter feature. The Slack Twitter integration does this a lot better than we can ever do.
Why are we doing this
This feature was originally implemented to get around having to ask Workspace Admins to change some settings. Now that I have access to Slack integration settings, I can use the better integration.
How should this be tested
Do tests still pass?
Migrations
Deleting keyvalue table since we don't need it. Can always create it again if required.
Dependencies
n/a
Callouts