search

busy-beaver-dev / busy-beaver

The Chicago Python Community Engagement Slack bot
https://busybeaverbot.com
MIT License
70 stars 23 forks source link

Merge dictionaries using new operator in Python 3.9 #336

Closed alysivji closed 4 years ago

alysivji commented 4 years ago

Closes #110

What does this do

Using new dictionary update operator in Python 3.9 to clean up code.

Why are we doing this

Makes everything a bit more readable.

How should this be tested

do tests pass? then we are good

Migrations

n/a

Dependencies

n/a

Callouts

n/a

codecov-io commented 4 years ago

Codecov Report

Merging #336 into master will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   89.87%   89.93%   +0.05%     
==========================================
  Files          71       71              
  Lines        2499     2493       -6     
==========================================
- Hits         2246     2242       -4     
+ Misses        253      251       -2
Impacted Files Coverage Δ
busy_beaver/common/wrappers/github.py 95.37% <100.00%> (-0.09%) :arrow_down:
busy_beaver/common/wrappers/requests_client.py 97.05% <100.00%> (+4.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 841568e...97b1893. Read the comment docs.