busybox11 / NowPlaying-for-Spotify

A Spotify Connect visualizer
https://nowplayi.ng
GNU General Public License v3.0
183 stars 23 forks source link

Artwork-only mode #71

Closed stephanebruckert closed 2 years ago

stephanebruckert commented 2 years ago

Hey @busybox11,

I'm using your project to project :-) my currently playing song on a wall using a raspberry pi:

However my initial goal was to only display the artwork, something like:

Here is a prototype https://61969ee4bf0a8a8c486890f9--jovial-liskov-02cc5a.netlify.app/. That's basically the artwork using 100% height, centered vertically with a black background.

Would you be open to a PR that adds a mode to switch to artwork-only? I think your app is great and was thinking there is no point creating a new one!

Thank you

VoXaN24 commented 2 years ago

You can made one, free to Busy to accept it or not, Btw that not an issue, please use the correct thing for it

Issue Closed - Not an Issue

stephanebruckert commented 2 years ago

@VoXaN24 thanks for the response, however you're not helping by closing this. Feature requests go in the issues section.

I was specifically asking whether @busybox11 would be accepting a pull request that implements this and your answer is basically repeating the question

VoXaN24 commented 2 years ago

@VoXaN24 thanks for the response, however you're not helping by closing this. Feature requests go in the issues section.

I was specifically asking whether @busybox11 would be accepting a pull request that implements this and your answer is basically repeating the question

Read my anwser thanks

stephanebruckert commented 2 years ago

I would like the idea approved before I put in any work towards a PR

VoXaN24 commented 2 years ago

Made a PR, we can reject it if we dont like or it has a problem with the Idea. Btw Features idea must be made in the discord

stephanebruckert commented 2 years ago

I'll join the discord so we can discuss implementation details beforehand – thanks