search

busyloop / lolcat

Rainbows and unicorns!
BSD 3-Clause "New" or "Revised" License
6.11k stars 219 forks source link

fix rounding in rainbow() #120

Open landfillbaby opened 3 years ago

landfillbaby commented 3 years ago

this is my first ruby code! i hope it works! this way the colours are a sine wave from 0-255, rounded properly :) the current code is 1-255

mathieu-aubin commented 2 years ago

essentially, this adds the missing 256th color? as in 0 to 255? COLOR_NUMBER=$(255+1) two-five-six, that add the 0, (zero, not null maybe) is it just making the rainbow use two hundred and fifty six colors?

OH! NO! what a terrible mistake i made. It doesnt add anything but the (very small) possibility of enfing up generating rgb(0,0,0) which would really suck on a black background terminal

Im just having fun with you, hahhàaha... no harm intended. Felt like throwing some bad humor while i ping this

Oh, also... when you say "hope it works" - does it mean you havnt tried?

galastiaos commented 11 months ago

BTW i think you guys should probably fix this issue- its been open for 2 years now