busypeoples / revalidation

Higher Order Component for Validating Forms in React
MIT License
379 stars 20 forks source link

Split examples into separate folders #22

Open bookercodes opened 7 years ago

bookercodes commented 7 years ago

At the moment, example has a lot of "boilerplate" to accommodate multiple use-case demos, which can make the code harder than necessary to follow and understand.

Rather than having one example folder, let's create an examples folder with a sub-folder for each demo, e.g.:

+ examples
 | basic-form-validation
 | asynchronous-form-validation
 | password-form-validation

I propose we use react-scripts to remove the need for webpack.config.js and other files not related to Revalidation. We should also use minimal styling in this folder to keep the examples focused on how Revalidation works 👍.

We could consider building a nice-looking demo for the website but keeping it separate from examples?

busypeoples commented 7 years ago

Yes, makes sense. We can add a styled example with Rebass or SC.

bookercodes commented 7 years ago

So, I am thinking these would be some good examples:

What do you think? Also, what else can we add?

busypeoples commented 7 years ago

Sounds great. Maybe a rebass example? https://www.webpackbin.com/bins/-KnG58K1TEbUzSmRsmD5