search

busypeoples / spected

Validation library
MIT License
703 stars 32 forks source link

Local build errors #103

Open arizonatribe opened 6 years ago

arizonatribe commented 6 years ago

I cloned the repo and started playing with the code locally but I ran into some problems just getting it to build. Perhaps this isn't causing a problem for anyone currently, but I suspect if you were to remove the node_modules/ folder and globally remove your versions of babel-eslint you might encounter the same problems I ran across.

It seems there was a bug in babel-eslint that doesn't play well with Flow, but it was corrected in version 8.1.1. For me it was causing the npm test command to fail. Anyway, a simple upgrade of that package fixed it.

Additionally, I ran into an error when building Spected that looked like a simple CommonJs failure to recognize the Object rest spread operator. I fixed it by moving the rollup commonjs() call (in the rollup.config.js) so that it comes after the babel() transpile step.

Hope this is helpful.

busypeoples commented 6 years ago

Thanks for the very valuable feedback @arizonatribe Will try to reproduce the error in the coming days.