search

but0n / Ashes

WebGL2.0 3D Engine - Global Illumination - RayTracing
https://codepen.io/but0n/pen/jddYoX
MIT License
328 stars 16 forks source link

In v.0.0.45, models without texture are not displayed #16

Closed cx20 closed 5 years ago

cx20 commented 5 years ago

I got Ashes v0.0.45 from jsDelivr and tried it locally. As a model, I tried Triangle.gltf, Box.gltf etc. However, the following error was output to the console and it was not displayed.

ashes.main.js:4356 
Uncaught (in promise) TypeError: Cannot read property '0' of undefined
    at Function.preComputeTangent (ashes.main.js:4356)
    at mesh.primitives.map.meshData (ashes.main.js:5500)
    at Array.map (<anonymous>)
    at gltf.meshes.gltf.meshes.map.mesh (ashes.main.js:5485)
    at Array.map (<anonymous>)
    at new gltfScene (ashes.main.js:5484)
    at Function.<anonymous> (ashes.main.js:5825)
    at Generator.next (<anonymous>)
    at fulfilled (ashes.main.js:5198)

Perhaps it seems that it is in error because uv is undefined. image

I think that it was not an error in the previous version v.0.0.44.

but0n commented 5 years ago

Yeah, the uv coords is not defined, it should be fixed at commit #ee17fc.

I’ll release this patch in 0.0.46 after #15.

cx20 commented 5 years ago

I confirmed that this problem was solved with v.0.0.46.