search

butaixianran / Stable-Diffusion-Webui-Civitai-Helper

Stable Diffusion Webui Extension for Civitai, to manage your model much more easily.
2.4k stars 287 forks source link

SD.Next Extra Networks Update breaks button display #206

Closed Aptronymist closed 11 months ago

Aptronymist commented 1 year ago

There was a significant update to SD.Next's Extra Networks today and it has broken the buttons showing up on cards or thumbnails.

Screenshot from inside browser dev mode of error location. vivaldi_XkRGHtK4Te

Please advise?

Thank you in advance.

HeartlessAUS commented 1 year ago

for context, below is the commit that breaks Civitai Helper: https://github.com/vladmandic/automatic/commit/8000d1965d7fc87ef1cc34adc09a124dd053bb36 errors also include: found active tab: undefined - civitai_helper.js?1688214514.8089392:438

Aptronymist commented 1 year ago

for context, below is the commit that breaks Civitai Helper: vladmandic/automatic@8000d19 errors also include: found active tab: undefined - civitai_helper.js?1688214514.8089392:438

Edit (for being an idiot on a phone, my apologies): I'm trying to see if anyone had any ideas as to addressing it before complaints start rolling in.

HeartlessAUS commented 1 year ago

I know which commit it was. I was testing it. I'm trying to see if you had any ideas as to addressing it before you started getting complaints.

I'm not the developer of Civitai-Helper, i'm simply giving some more information so that it can be fixed quicker on this side (if that's what is needed) :)

Aptronymist commented 1 year ago

I know which commit it was. I was testing it. I'm trying to see if you had any ideas as to addressing it before you started getting complaints.

I'm not the developer of Civitai-Helper, i'm simply giving some more information so that it can be fixed quicker on this side (if that's what is needed) :)

My bad, this is why I hate using the mobile app.

ColorfanXP commented 1 year ago

Is development on this pretty much dead at this point? It really hasnt been touched in months, despite its issues.

Aptronymist commented 1 year ago

Is development on this pretty much dead at this point? It really hasnt been touched in months, despite its issues.

I have to assume so, there's been no activity for months, even the youtube video for "version 2" is 3 months old and no updates. I had no idea this was essentially a dead project. A shame.

gsgoldma commented 1 year ago

there's forks that of it that are maintained more recently, but they too seem to be suffering the same problem.

aleph23 commented 1 year ago

Yeah @gsgoldma, I checked @goldmojo and no updates there. I haven't had time to look into these breaking changes (I'm on Vlad's auto1111 implementation) for my fork. The number of recent updates has been tough to keep up with. The new Diffusers back-end option, for example, damn near broke everything for me.

goldmojo commented 1 year ago

Yeah @gsgoldma, I checked @goldmojo and no updates there. I haven't had time to look into these breaking changes (I'm on Vlad's auto1111 implementation) for my fork. The number of recent updates has been tough to keep up with. The new Diffusers back-end option, for example, damn near broke everything for me.

I use this workaround in webui, not in the extension : => Edit stable-diffusion-webui/style.css => Add this lines on top (line 13 in my style.css file)

.extra-network-thumbs .actions .additional {
    position: relative;
    }

It may resolve the issue.

gsgoldma commented 1 year ago

Yeah @gsgoldma, I checked @goldmojo and no updates there. I haven't had time to look into these breaking changes (I'm on Vlad's auto1111 implementation) for my fork. The number of recent updates has been tough to keep up with. The new Diffusers back-end option, for example, damn near broke everything for me.

I use this workaround in webui, not in the extension : => Edit stable-diffusion-webui/style.css => Add this lines on top (line 13 in my style.css file)

.extra-network-thumbs .actions .additional {
    position: relative;
    }

It may resolve the issue.

I'm using vlad's fork, so I don't think that solution will work in my case because there is no styles.css file. I wonder if there's a similar work around though.

goldmojo commented 1 year ago

My bad, I read too quickly.

gsgoldma commented 1 year ago

My bad, I read too quickly.

Actually, it does have one. It was just in the javascript folder. Not sure if it's in a different order than auto's though.

goldmojo commented 1 year ago

My bad, I read too quickly.

Actually, it does have one. It was just in the javascript folder. Not sure if it's in a different order than auto's though.

I just had a quick look, it seems to be the same. Did you try to add those 3 lines in your style.css inside javascript folder ?

aleph23 commented 1 year ago

EDIT: Found breaking commit. 8000d19

It's actually diverged from auto1111 quite a bit now. Here's the full extent of references to the "extra-network" in Vlad's style.css

/ extra networks / .extra-networks > div { margin: 0; gap: 0.2em; border-bottom: none !important; } .extra-networks .second-line { display: flex; width: -webkit-fill-available; gap: 0.2em; } .extra-networks .search { flex: 1; } .extra-networks .description { flex: 3; } .extra-networks .tab-nav > button { margin-right: 0; height: 24px; padding: 2px 4px 2px 4px; } .extra-networks-tab { padding: 0 !important; } .extra-network-subdirs { background: var(--input-background-fill); overflow-x: hidden; overflow-y: auto; min-width: 120px; } .extra-networks-page { display: flex } .extra-networks .custom-button { width: 120px; width: 100%; background: none; justify-content: left; text-align: left; padding: 2px 8px 2px 16px; text-indent: -8px; box-shadow: none; line-break: auto; } .extra-networks .custom-button:hover { background: var(--button-primary-background-fill) } .extra-network-cards { display: flex; flex-wrap: wrap; overflow-y: scroll; overflow-x: hidden; width: -webkit-fill-available; } .extra-network-cards .card { height: fit-content; margin: 0.5em; position: relative; scroll-snap-align: start; scroll-margin-top: 0; } .extra-network-cards .card .overlay { position: absolute; bottom: 0; padding: 0.2em; z-index: 10; width: 100%; background: none; } .extra-network-cards .card:hover .overlay { background: rgba(0, 0, 0, 0.40); } .extra-network-cards .card .overlay .name { font-size: 1.2em; font-weight: bold; line-break: anywhere; text-shadow: 1px 1px black; color: white; } .extra-network-cards .card .overlay .actions { font-size: 1.8em; display: none; text-align-last: justify; cursor: pointer; word-spacing: -6px; } .extra-network-cards .card:hover .overlay .actions { display: block; } .extra-network-cards .card .overlay .description { line-break: anywhere; display: none; color: white; } .extra-network-cards .card:hover .overlay .description { display: block; } .extra-network-cards .card .preview { box-shadow: var(--button-shadow); min-height: 30px; } .extra-network-cards .card:hover .preview { box-shadow: none; }

no longer any reference to "-thumbs" or ".actions"

Aptronymist commented 1 year ago

Yeah @gsgoldma, I checked @goldmojo and no updates there. I haven't had time to look into these breaking changes (I'm on Vlad's auto1111 implementation) for my fork. The number of recent updates has been tough to keep up with. The new Diffusers back-end option, for example, damn near broke everything for me.

Sorry about all of that, it's been a hell of a couple of weeks with a ton of changes and advancements going in around Diffusers/SDXL/Kandinsky, including on the UI front obviously. In fact we have a snazzy new loading screen that just dropped.

aleph23 commented 1 year ago

Sorry about all of that, it's been a hell of a couple of weeks with a ton of changes and advancements going in around Diffusers/SDXL/Kandinsky, including on the UI front obviously. In fact we have a snazzy new loading screen that just dropped.

@Aptronymist I know! It's been dizzying trying to keep up while also keeping personalizations.

Auto1111 had a couple functions in 'script,js' that were removed from SD.Next about 3 weeks ago and has caused issues for a few extensions: get_uiCurrentTab & get_uiCurrentTabContent

Any idea if their removal was necessary? Here's another recent issue mentioning both SD.Next and this function: #https://github.com/Nevysha/Cozy-Nest/issues/182#issue-1803978320

get_uiCurrentTabContent is used in the following extensions:

You guys might consider taking a day or two off, so everyone else can catch up! ;->

Aptronymist commented 1 year ago

Sorry about all of that, it's been a hell of a couple of weeks with a ton of changes and advancements going in around Diffusers/SDXL/Kandinsky, including on the UI front obviously. In fact we have a snazzy new loading screen that just dropped.

@Aptronymist I know! It's been dizzying trying to keep up while also keeping personalizations.

Auto1111 had a couple functions in 'script,js' that were removed from SD.Next about 3 weeks ago and has caused issues for a few extensions: get_uiCurrentTab & get_uiCurrentTabContent

Any idea if their removal was necessary? Here's another recent issue mentioning both SD.Next and this function: #Nevysha/Cozy-Nest#182 (comment)

get_uiCurrentTabContent is used in the following extensions:

Rest assured, I will pass this along immediately, breaking extensions was a big concern, especially with implementing the Diffusers backend, which broke even more, but there were a lot of changes that needed to be made. Expect a response soon, and thank you for the information!

You guys might consider taking a day or two off, so everyone else can catch up! ;->

Today was a pretty light day, you caught up yet? 😆

Aptronymist commented 1 year ago

Sorry about all of that, it's been a hell of a couple of weeks with a ton of changes and advancements going in around Diffusers/SDXL/Kandinsky, including on the UI front obviously. In fact we have a snazzy new loading screen that just dropped.

@Aptronymist I know! It's been dizzying trying to keep up while also keeping personalizations.

Auto1111 had a couple functions in 'script,js' that were removed from SD.Next about 3 weeks ago and has caused issues for a few extensions: get_uiCurrentTab & get_uiCurrentTabContent

Any idea if their removal was necessary? Here's another recent issue mentioning both SD.Next and this function: #https://github.com/Nevysha/Cozy-Nest/issues/182#issue-1803978320

get_uiCurrentTabContent is used in the following extensions:

You guys might consider taking a day or two off, so everyone else can catch up! ;->

If you have a list of extensions with issues, please give it to me, I'm preparing to have my support volunteers go through all the extensions and test them to see if they are working correctly on both backends, so anything you know, or anything anyone you know knows would be a helpful head start. Once I can get all of that data we will see what can be done to address compatibility.

aleph23 commented 1 year ago

@Aptronymist Off the top what I can say is: stable-diffusion-webui-embedding-editor needs the 'seed = ' updated because it uses the "cmd_opts.use_textbox_seed" that's no longer found in modules/shared.py

This extension (Civitai Helper) I still get errors that cause load failure. New error is

\0_Civitai-Helper\scripts\civitai_helper.py:122 model_type_drop = gr.Dropdown(choices=model_types, label="Model Type", value="ti", "hyper", "ckp", "lora" **SyntaxError: positional argument follows keyword argument**

Duplicating might require using a fork with lycoris support (like mine or goldmojo's) though the base should be tried first, of course. In fact, if it's only present in the fork then please let us know as that would make it our problem, not yours. :))

Aptronymist commented 1 year ago

@Aptronymist Off the top what I can say is: stable-diffusion-webui-embedding-editor needs the 'seed = ' updated because it uses the "cmd_opts.use_textbox_seed" that's no longer found in modules/shared.py

This extension (Civitai Helper) I still get errors that cause load failure. New error is

\0_Civitai-Helper\scripts\civitai_helper.py:122 model_type_drop = gr.Dropdown(choices=model_types, label="Model Type", value="ti", "hyper", "ckp", "lora" SyntaxError: positional argument follows keyword argument

Duplicating might require using a fork with lycoris support (like mine or goldmojo's) though the base should be tried first, of course. In fact, if it's only present in the fork then please let us know as that would make it our problem, not yours. :))

We do have our own system in place for extensions, so we're not directly drawing from the a1111 list. We can exclude some, mark as not working, etc, as well as inject some, which I have a few, like a working LLuL. If there's a fork of this that is up to date and works with SD.Next (you guys figure that out amongst yourselves?) then I'm happy to use one or both of them in our list and wipe this one off of it so it's not even available.

Edit: Actually, now that I think about it, if @aleph23 and @goldmojo both know working with the civitai API well enough, we are looking at having integrated Civitai support just like the huggingface downloader (basic, but it works), although it would clearly have to be a lot more elaborate and functional for such a media rich site. That would essentially eliminate a need for this app, if you'll notice there's a new # symbol on the EN boxes that's supposed to insert a keyword, that is a small part of it. Hit me up if you would like to collaborate on it, I can set you up for a confab with vlad if that would be something you'd be interested in. We always love collaborating, the more the merrier!

HeartlessAUS commented 1 year ago

I created a fork for a temporary fix https://github.com/HeartlessAUS/Stable-Diffusion-Webui-Civitai-Helper

Aptronymist commented 1 year ago

I created a fork for a temporary fix https://github.com/HeartlessAUS/Stable-Diffusion-Webui-Civitai-Helper

I will give that a shot and place I to our custom extension list if approved.

butaixianran commented 11 months ago

Done, check new version. Also there is a fork keeps catching up with latest sd webui. https://github.com/zixaphir/Stable-Diffusion-Webui-Civitai-Helper