with PHP 8 I got error "require int, null given"

butschster / LaravelMetaTags

The most powerful and extendable tools for managing SEO Meta Tags in your Laravel project

MIT License

547 stars 51 forks source link

with PHP 8 I got error "require int, null given" #26

Closed DenisDangerous closed 4 years ago

DenisDangerous commented 4 years ago

src/MetaTags/Entities/Title.php with PHP 8 I got error "require int, null given"

fix it with adding "|null" line 39: public function __construct(string $title = null, int|null $maxLength = self::DEFAULT_LENGTH)

butschster commented 4 years ago

Hi! I couldn't use __construct(string $title = null, int|null $maxLength = self::DEFAULT_LENGTH) this style, because this code is incompatible with 7.x version. I've made some fixes and you can try new version.