search

butschster / LaravelMetaTags

The most powerful and extendable tools for managing SEO Meta Tags in your Laravel project
MIT License
547 stars 51 forks source link

Fix custom tag documentation #42

Closed loranger closed 3 years ago

loranger commented 3 years ago

Mandatories abstract implementations were missing

butschster commented 3 years ago

Could you provide unittest for this changing?

loranger commented 3 years ago

I'm afraid I can't test mandatories interface methods are well documented in readme file

loranger commented 3 years ago

@butschster I can't find existing unit test for documentation changes, can you please show me the kind of test you need

butschster commented 3 years ago

@butschster I can't find existing unit test for documentation changes, can you please show me the kind of test you need

Oh sorry. Yesterday I didn't notice that you fixed docs))) My fault.

But it would be great if you cover with test this changing https://github.com/butschster/LaravelMetaTags/blob/master/src/MetaTags/Entities/Webmaster.php#L25

butschster commented 3 years ago

@loranger Thank you for help!

loranger commented 3 years ago

But it would be great if you cover with test this changing https://github.com/butschster/LaravelMetaTags/blob/master/src/MetaTags/Entities/Webmaster.php#L25

Done !