search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
227 stars 42 forks source link

Safari support #105

Open perry-mitchell opened 6 years ago

perry-mitchell commented 6 years ago

Add support for Safari: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/SafariExtensionsConversionGuide/Chapters/Chrome.html

muellmaa commented 6 years ago

So where is this available at?

perry-mitchell commented 6 years ago

@muellmaa What do you mean? The status is "Available", as in yet-to-be-implemented.

perry-mitchell commented 5 years ago

Things to do to make this work:

agustif commented 5 years ago

Hi, is anyone interested or currently developing the safari extension for buttercup? If not I would love to try a stab at if anyone else doesn't object. or already is building a solution currently that I'm not aware of.

perry-mitchell commented 5 years ago

@agustif That’d be swell! It’s not currently in development. It should be extended off of the current extension repo, perhaps using another webpack entry point if needed.

We’d really appreciate the help!

Vinz87 commented 5 years ago

Is the Safari support still planned? It's the only thing that prevents me from trying Buttercup! :)

ziulev commented 3 years ago

Is the Safari support still planned? It's the only thing that prevents me from trying Buttercup! :)

For me the same.

Any update here?

perry-mitchell commented 3 years ago

This issue might become irrelevant in its current form when it's possible to port web extensions to the new Safari (article). I don't think we'll bother supporting older versions of Safari if this is possible.

david-shortman commented 3 years ago

Converting an existing web extension is easy with the Xcode cli tool safari-web-extension-converter: https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari

david-shortman commented 3 years ago

A great thing about Safari extensions based on web extensions is that the directory for the macOS code can be kept in the same repo as the extension without holding duplicate JS/manifest/other extension files. The project.pbxproj file is set up with references to the extension files when the cli converter tool is used in the repo, like so: https://github.com/david-shortman/readable/blob/main/Readable/Readable.xcodeproj/project.pbxproj#L64