buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
236 stars 42 forks source link

Adding archive failed: t is null #164

Closed cwmke closed 6 years ago

cwmke commented 6 years ago

Firefox Linux - 61.0.2 (64-bit) Buttercup Extension - 1.11.0 Nextcloud Server - 13.0.5

I successfully login to Nextcloud but I receive the below t is null error after selecting the file and entering the password. I checked Nextcloud's logs and everything looks good. The bottom block shows some warnings when the extension page first loads.

I attempted the below in a fresh Firefox profile with no other extensions installed.

makeArchiveAdditionRequestmoz-extension://096f3139-b84a-4752-aeae-9296ed68b301/setup-index.js:1:29105 setup-index.js:1:90329
onChooseWebDAVBasedArchive/</<
moz-extension://096f3139-b84a-4752-aeae-9296ed68b301/setup-index.js:1:90329
The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol. setup.html
Content Security Policy: The page’s settings blocked the loading of a resource at self (“script-src”). Source: call to eval() or related function blocked by CSP.
perry-mitchell commented 6 years ago

Hi @cwmke - Thanks for the detailed report. Regarding the t is null error, do you have the full stack by any chance, including the full error message?

On the topic of nextcloud, can you reproduce the issue on Nextcloud's Demo account? If not, it is either:

When you tried adding an existing archive, was it one created using the Desktop application? Was the error the same?

fmommeja commented 6 years ago

Hi @perry-mitchell, the error also occurs on Firefox 61.0.2 (64 bits) & Chrome 68.0.3440.106 (Build officiel) (64 bits) with Buttercup v. 1.11.0 on Windows 10 Pro Version 10.0.17134 Numéro 17134

First logging without error on Owncloud, Choosing Buttercup file on Owncloud, Error message appears after typing Name and Master Password then clicking on SAVE ARCHIVE:

on Firefox :

Failed selecting owncloud archive An error occurred when adding the archive: Adding archive failed: t is null

on Chrome :

Failed selecting owncloud archive An error occurred when adding the archive: Adding archive failed: Cannot read property 'getValue' of null

Firefox console attached... HTH

Kind regards Frederic FirefoxConsole20180826.txt

cwmke commented 6 years ago

@perry-mitchell I don't know how to get the stack trace but if you have any pointers for doing so in Firefox I'm happy to give it a go. I attempted to use the Nextcloud Demo Instance but it would not let me login using the Buttercup extension.

The existing archive I attempted to open was indeed created in the desktop application. Fedora 28 using buttercup-desktop-1.10.1.x86_64.rpm.

SysLunix commented 6 years ago

same thing on Arch Linux, Firefox Buttercup Extension V1.11.0 , Nextcloud instance installed over SSL on Debian 9 server

perry-mitchell commented 6 years ago

I was able to reproduce, and I've made a patch. Very sorry about the inconvenience!

The patch will come out as 1.11.1.