search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
230 stars 42 forks source link

Managing vaults: new entry never been saved #253

Closed snakewa closed 5 years ago

snakewa commented 5 years ago

In chrome v2.7.0, in Managing vault interface, add new entry never been saved. It is said successfully saved in green notification, but Cmd+R refresh the page, the entry will be gone. but edit exiting entries from Desktop or save from login form is ok

perry-mitchell commented 5 years ago

Confirmed - I can see that the entry isn't saved.. Thanks @snakewa

Temurson commented 5 years ago

Is it already fixed? I am still experiencing this issue in using the Chrome extension v2.8.0. I am storing my vault in Dropbox. When I add any kind of entry using the extension, it is not being saved (just as in description above).

jokeyrhyme commented 5 years ago

@Temurson yeah, I don't think v2.8.0 on Firefox is saving to the vault persistently, either I have to use the Windows / macOS desktop version of Buttercup to achieve this for now

perry-mitchell commented 5 years ago

I tested it and it worked when releasing, so not sure what might be happening. I'll try to confirm it again, with dropbox, as soon as I can.

jokeyrhyme commented 5 years ago

I was saving to Dropbox and it wasn't working, although the toast/notification thing in the top-right would say that it was saved Is it possible that the toast is popping up before it is finished? Maybe I"m closing the window too quickly...

perry-mitchell commented 5 years ago

Ok, I can confirm that this has returned ☹️

It affects all datasource types, too.

perry-mitchell commented 5 years ago

Ok, finally found the issue. The UI library was providing a UUID to new blank entry IDs, which it shouldn't do, when it's new. The facade library (which maps changes back to vaults after editing them in the manage-vault section) was mistakenly thinking it was an existing entry when it wasn't.

perry-mitchell commented 5 years ago

Released the fix in 2.8.1.

LividJava commented 4 years ago

2.18.0 seems to have this issue come back up?? not certain if this is reproducible (Firefox 79 Dev edition)

Apologies for necropost

jokeyrhyme commented 4 years ago

I saved an entry using the vault manager interface (not the flow starting from the top-right in-page pop-up) yesterday with Firefox 78 and Buttercup extension 2.18.0 combined with the Google Drive backend, and I can confirm that it did persist the changes correctly: other devices can view the new value when connecting to the same backend via Buttercup

@LividJava which flow did you use? Starting from the vault manager interface? Or from the top-right in-page pop-up? And which storage backend are you using? Is it possible that you closed Firefox before the changes were properly persisted (I'm not sure if Buttercup's progress/activity indicators represent the full amount of work required)?

tourtools commented 4 years ago

same behaviour with 2.18.0 and the last version of Brave (chromium)

LividJava commented 4 years ago

I saved an entry using the vault manager interface (not the flow starting from the top-right in-page pop-up) yesterday with Firefox 78 and Buttercup extension 2.18.0 combined with the Google Drive backend, and I can confirm that it did persist the changes correctly: other devices can view the new value when connecting to the same backend via Buttercup

@LividJava which flow did you use? Starting from the vault manager interface? Or from the top-right in-page pop-up? And which storage backend are you using? Is it possible that you closed Firefox before the changes were properly persisted (I'm not sure if Buttercup's progress/activity indicators represent the full amount of work required)?

My vaults usually just disappear after restarting my browser, using either flow, and i have a local bcup file for my backend storage