search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
236 stars 42 forks source link

Sometimes shows on inputs not meant for logins #261

Closed divyanshu013 closed 5 years ago

divyanshu013 commented 5 years ago

Hi,

I noticed sometimes buttercup button shows up on input fields which are not meant for login (I guess it checks input type email which is common in subscription boxes).

Please check the following screenshot:

Thanks

perry-mitchell commented 5 years ago

Hi @divyanshu013 - I've seen this also, but it's something that I've noticed all password managers doing.. And I'd say that it's somewhat deliberate in a lot of cases. For us it's not accidental nor deliberate, but a side-effect of how we detect inputs - like you suggested.

Sure Buttercup is a password manager, but it also remembers all of your accounts. Prefilling an email address could also be done using Buttercup.

I'm not sure if we want to stop this functionality, as attempting to filter certain forms or pages could well do more harm than good. For now we'll keep it as is, but will treat breaking form recognitions on a case-by-case basis. Thanks :)

divyanshu013 commented 5 years ago

Sounds good, thanks 👍