search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
230 stars 42 forks source link

Iframe penetration #288

Closed ivanovd closed 5 months ago

ivanovd commented 4 years ago

When you go on AliExpress.com and you try to login you don't get the option to auto-fill the saved login on the Log in tab, but only on the Sign up tab.

I suspect that it has something to do with the HTML and CSS as this is on one modal window with two tabs, but still it would be nice to handle such scenarios.

Examples:

Annotation 2019-10-16 155417 Annotation 2019-10-16 155449 Annotation 2019-10-16 155512
bigalgeorge commented 4 years ago

Agreed; I have the same, but note that Aliexpress does not work for most pwm as their login fields are weird. Keepassxc browser has a method which is meant to copy the frame code for recognizing as a user and password field but Ive never got that to work. Buttercups instantiate the login fields usually works more robustly than Keepassxc but not on this url.

perry-mitchell commented 4 years ago

Ah, I got a bit confused. Initially I thought this was about targeting more than one form (#289), but as @bigalgeorge mentioned this is indeed about the login fields themselves.

Aliexpress uses an iframe for the actual login fields, which is weird since they don't do the same for the registration. Nevertheless this is a common occurrence and injecting our script within the iframe is the only way.

perry-mitchell commented 5 months ago

Solved in V3.