search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
230 stars 42 forks source link

[MS Edge] Auth information not updated - Google Drive not working correctly #319

Closed Peppeo closed 4 years ago

Peppeo commented 4 years ago

Also related to issue #317. Testdriving the new Edge browser on Mac. Installed Buttercup extension from the Chrome store. Adding my vault: 1.Choose Google Drive: Screen Shot 2020-01-17 at 08 56 36 2.Connect Google account: Screen Shot 2020-01-17 at 08 56 46

  1. Grant access to Buttercup: Screen Shot 2020-01-17 at 08 57 01
  2. Get thrown back to the selection screen: Screen Shot 2020-01-17 at 08 57 12 N.B. This did not happen to me when using Chrome or Firefox but there I could not browse the Drive itself.
  3. Follow exactly the same procedure on Dropbox and can a. browse the contents of the drive and b. add the vault to Buttercup. Screen Shot 2020-01-17 at 09 02 10
perry-mitchell commented 4 years ago

We don't test regularly on Edge, so this is probably something to do with how Edge manages browser events. It may require changes to our build system, which I'd prefer to delay as long as possible. But would be happy to see a PR or some discussion surrounding this.

We definitely DO want to support the new Edge as a first-party browser.

perry-mitchell commented 4 years ago

Confirmed, there seems to be some issue in Edge:

image

perry-mitchell commented 4 years ago

Found the issue! It was a decoding error which somehow only appeared in Edge. I've fixed it:

image

Expect it in 2.12.0.

Peppeo commented 4 years ago

Ok @perry-mitchell thanks for the heads-up and the time (as ever); I can indeed confirm it works with the latest 2.12 on Edge also.