search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
230 stars 42 forks source link

Input icon/button: Minimal / Hidden modes #334

Closed divyanshu013 closed 5 months ago

divyanshu013 commented 4 years ago

Hi, sometimes the buttercup icon doesn't match well with the styles of a site or breaks the styling of input fields. Would it be possible to have an alternate minimal icon that shows up in the input field?

For reference on github login:

  1. last pass
image
  1. buttercup
image

Happy to send a PR if you also feel the same.

perry-mitchell commented 4 years ago

This is a good point, but I personally like the buttercup icon being outside the input. Placing a button inside the input isn't safe, for clicks etc. - it's also not how inputs were designed to be used.

That being said, yes, the buttercup button does break some forms. We've been considering our options here for some time, and would love more opinions on the matter. Any and all suggestions here will be considered.

I'd place the following restrictions on an update here:

  1. Only one button style (we don't want a setting for multiple, or different buttons per site)
  2. Ideally not a button inside the input
  3. Ideally doesn't conflict with other password managers (like lastpass)

I've seen several people using multiple PW managers, like lastpass and buttercup, for instance, and this makes it difficult as I'd like to avoid button conflicts with them. Placement inside but on the left side of the input is also tricky as lots of inputs have icons in them these days..

kimus commented 2 years ago

Personally I don't like buttons added to inputs. So many things that could break because of that (at least the original esthetics of the design of the page) and was mentioned some of them in this thread.

So, for me this is not a very good integration with login form:

image

And if the designer doesn't put overflow: hidden; in the parent container it could add a scroll to it. So, there's pros and cons with putting outside or inside the input.

I would love an option (not found any) to not to show the button at all and use the context menu to interact with Buttercup options.

image
nerdCopter commented 1 year ago

The extension really needs an option to disable the in-field icons altogether. Agree with @kimus ' idea of context menu as well.

perry-mitchell commented 5 months ago

Continued in #464