Enhance save login details detection #Enhancement

[ldexterldesign]

Hi!

Hope you're well

Thanks for amazingly useful software

Leading on from #287 (the only list item without it's own issue 😏):

Better detection of whether or not to show the save dialog

... I, too, think the save login details prompt should be more intelligent (i.e. if a vault entry/login match already exists then don't prompt me to re-save it)

The prompt is pretty annoying to the point where I've considered manually disabling it for every entry/login in my vault(s) but really this should be automated with some intelligence

Screen shot/cast:

This begs the question of intelligence...

I imagine the logic for this has already been solved elsewhere in the codebase, and I'm massively trivialising it here, but some match on a hostname (i.e. (local.)domain.com) will NOT trigger a prompt

If you're reading and:

• agree, then please vote up (e.g. +1, like), or;
• disagree, then please vote down (e.g. -1, dislike) - I'd love to know why?

Welcome feedback/input

If you have any issues (e.g. questions/queries) then happy to help

Keep up sterling work!

Hope this helps & to hear back

Sincerely

PS Related but distinct enough to warrant it's own issue here

[swanknight]

I totally agree.

I thought it was a bug, why is it asking me to ask me to save a password it just entered? It should only prompt if the credentials are NOT saved already. Also, the dialog should be improved. Why do I have to manually choose the vault and category every single time? There should be default values.

It's a shame, but I'll remove it until these issues are fixed.

[perry-mitchell]

Sorry for the long delay on this one - I completely agree with the reasoning here. It is annoying.

I've made an update so that if you log in using an existing entry, the prompt will not show. It will only show for manual input. It's set using a simple flag, to identify if it was from an entry or manual. There are 3 ways this flag can be set:

• When clicking the entry in the search results dialog
• When clicking the auto-login button in the search results dialog on-page
• When clicking the auto-login button in the extension menu search results

Once the flag is set, it cannot be unset without refreshing or changing pages. This is purely to reduce development effort and potential bugs.

Please expect this in the 2.18.0 release.

[nerdCopter]

@buttercup, i'm a new user of BC Sept 2022 ... i thought the behavior i'm experiencing was was a bug and intended to submit issue, but it seems already addressed (in 2.18 as commented above); however, it's not working as intended for me. I've imported my lastpass data to migrate to BC. I can use the BC Firefox Extension to login to almost all my usual logins; However, it also asks to save new entry each and every time. i don't necessarily want to disable for domains, but rather it not ask for existing saved entries.

BC FF extension version 2.25.2 Linux Firefox ESR version 91.13.0esr

Recommend maybe enabling Github Discussions or Discord server for "support" https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/enabling-or-disabling-github-discussions-for-a-repository https://support.discord.com/hc/en-us/articles/204849977-How-do-I-create-a-server-

[ldexterldesign]

Recommend maybe enabling Github Discussions or Discord server for "support"

FYI There's a GitHub discussions feature (e.g. foo), which could be used for support

Hope this is useful

Regards

PS BC and these repos are managed wonderfully BTW 🙂