Search doesn't find any results on 2.16

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension

https://buttercup.pw

MIT License

230 stars 42 forks source link

Search doesn't find any results on 2.16 #342

Closed ttamminen closed 4 years ago

ttamminen commented 4 years ago

I was able to get the Buttercup Browser Extension to a state where the search doesn't find anything even though the Vault is unlocked. The Buttercup version is 2.16 and I'm using Brave (Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)).

buttercup

Yesterday, everything worked correctly so I am assuming it is the latest release that broke the search.

morojgovany commented 4 years ago

Same thing, I think this il related to #197 with CORS restrictions, I added the headers 'Access-Control-Allow-Origin' '*' always "Access-Control-Allow-Headers" "Content-Type, Content-Length" always "Access-Control-Allow-Credentials" "true" always "Access-Control-Allow-Methods" "GET, POST, PUT, OPTIONS, PROPFIND, DELETE" always;

like suggested in #205 on my webdav and i'm still blocked, with the error in console net::ERR_BLOCKED_BY_CLIENT in chrome and Reason: CORS request not HTTP in firefox. edit : these errors finally not seems to be related to buttercup. mb

In firefox I have errors in eval (« script-src ») due to Content Security Policy in dialog-buttercup.js & dialog-index.js In chromium TypeError: group.getGroup is not a function in background-index.js is visible in extensions debug.

Any advice would be welcome ! Thanks

ldexterldesign commented 4 years ago

Would be a relief to get these related issues done too: https://github.com/buttercup/buttercup-browser-extension/issues/150 https://github.com/buttercup/buttercup-browser-extension/issues/157 https://github.com/buttercup/buttercup-browser-extension/issues/283

Sincerely

moussaclarke commented 4 years ago

Possibly related - login inputs don't see that vault is unlocked since 2.16 update. Also have the same behaviour as detailed above with search.

Chrome 83.0.4103.116

moussaclarke commented 4 years ago

Above behaviour mentioned in separate issue https://github.com/buttercup/buttercup-browser-extension/issues/343

bulbil commented 4 years ago

Wow, thanks for addressing this so quickly @perry-mitchell ! Browser Extension release 2.16.1 resolves my issue (FF 76.0.1 / MacOS 10.14.6)

moussaclarke commented 4 years ago

2.16.1 resolves 👍 Think this can be closed!

ldexterldesign commented 4 years ago

Fixed in latest Firefox but not in latest Brave/Vivaldi so needs testing

Regards

ldexterldesign commented 4 years ago

Sorry, just seen Firefox has 2.16.2 while Brave/Vivaldi still has 2.16.1

Ignore me, presuming y'all are on it and waiting for Chrome Web Store to update...

Apologies

perry-mitchell commented 4 years ago

We're about to release (today) a new version with brand new searching. It uses fuse fuzzy searching for terms, and a domain-scoring search for URLs. It should hopefully prove better than the previous implementation. The version will be 2.17.0.