Refactor - Githubissues

ph1p commented 4 years ago

I have refactored and updated the extension a little bit. I know. It's a pretty big PR, but I tried to make it as clean as possible with my commits.

I have changed https://github.com/reactjs/react-router-redux to https://github.com/supasate/connected-react-router.
Changed react-router to react-router-dom
Refactoring of the webpack configuration and migration to newer plugins
- From uglify to terser
- Removed the json-loader, since it is now integrated
Import images instead of require them.
Add a fixed history version (v4.9.0), because v5 is buggy
Unused imports and variables removed
Remove unused packages (react-spinkit, query-string, sleep-promise and url-join)

perry-mitchell commented 3 years ago

I'm sorry @ph1p - I didn't see this before I'd already mostly finished core v5 upgrade, which has already gone live.. It's going to master now. We'll have to look at the conflicts here then afterwards.

ph1p commented 3 years ago

Alright! I can wait (:

perry-mitchell commented 3 years ago

@ph1p Done! Again, super sorry. I'm happy to go through this straight after you've addressed the conflicts.. Thanks!

ph1p commented 3 years ago

Fixed all suggestions in #364, because I got several errors in this branch and the extra work was not worth it.

buttercup / buttercup-browser-extension

Refactor #363