search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
228 stars 42 forks source link

i18n feature #364

Closed ph1p closed 3 years ago

ph1p commented 4 years ago

This PR adds i18n support. ~~It is not finished yet, because of missing translations. Please review #363 first, because this branch depends on it.~~

Issue: #271

I have refactored and updated the extension a little bit. I know. It's a pretty big PR, but I tried to make it as clean as possible with my commits.

I have changed https://github.com/reactjs/react-router-redux to https://github.com/supasate/connected-react-router.

Changed react-router to react-router-dom

Refactoring of the webpack configuration and migration to newer plugins

From uglify to terser Removed the json-loader, since it is now integrated Import images instead of require them.

Add a fixed history version (v4.9.0), because v5 is buggy

Unused imports and variables removed

Remove unused packages (react-spinkit, query-string, sleep-promise and url-join)

ph1p commented 3 years ago

Completely understand this is a draft! But it already looks awesome.. I'm very excited to see it come together. Made a couple of comments, mainly formatting - I think a lot of changes are due to the prettier config - once we reduce those changes it'll also be easier to review I think.

Thank you ☺️ Over the next few days I will try to search the application piece by piece for words and replace them with the translation function. I'll let you know when I'm done (:

perry-mitchell commented 3 years ago

Hi @ph1p! Hope all is well. There's a lot of great work on this MR but it's stagnated.. Any plans or possibilities in terms of cleaning it up so we might consider a merge? I'd recommend creating a new branch if so, with no dependency updates and just the translations. Please let me know if there's something from us you need - we just translated the UI portion (vault contents), and that would go extremely well with your additions!

ph1p commented 3 years ago

Hi perry! Sorry that the PR has come to a halt. Fortunately, I'm doing well so far and I hope you are too (: I also think it would be a good idea to create a new Branch. I'll get to work on it this week. Where can I find your translations?

ph1p commented 3 years ago

I'm closing this PR, because of my new one that only adds i18n support (#404)