Popup / Dialog very slow to open

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension

https://buttercup.pw

MIT License

228 stars 42 forks source link

Popup / Dialog very slow to open #368

Closed perry-mitchell closed 3 years ago

perry-mitchell commented 3 years ago

After running for some time, the popup menus are very slow to open.

perry-mitchell commented 3 years ago

Closing in favour of #370

perry-mitchell commented 3 years ago

Re-opening due to continual slowness that gets worse after some time. Memory and CPU are not growing for me, but might be for some other users. I suspect the issue is with the search system, which might be slow to populate. Need to run some timer checks in development to see where the slow part is.

ldexterldesign commented 3 years ago

FYI

My browser's been open for 24 hours and popup won't open at all

Had to restart browser

Hope it helps

Sincerely

perry-mitchell commented 3 years ago

Issue was with search performance, which has been improved in core and now in the extension.

ldexterldesign commented 3 years ago

Feel free to close issue

I'll come reopen if I don't see an improvement in the next week

❤️

perry-mitchell commented 3 years ago

Will be released as 2.23.1 :+1:

ldexterldesign commented 3 years ago

No, still not fixed for me

The search (inc. results) performance seems OK it's opening the actual popup after clicking the extension button/icon that's the issue. It opens a few times but then stops opening. Really unpredictable.

If I can be any further help then please let me know?

I suggest to reopen this issue

Sincerely

ldexterldesign commented 3 years ago

BUMP

I suggest to reopen this issue

I have a fresh macOS/Vivaldi combo and issue still exists

Let me know if/how I can be of further help..?

Sincerely

ldexterldesign commented 3 years ago

Managed to catch activity in task manager, looks to be CPU spikes causing the interaction delays (i.e. 100.3%)..?

Toolbar button, form buttons - everything locked up for up to 10 seconds sometimes

Hope this helps

Sincerely

ldexterldesign commented 3 years ago

So when I experience the delay...

Idle the extension is ~25-33% CPU:

... but if I click the extension button repeatedly then I can get CPU to ~125%:

Surely this shouldn't be expected behaviour..?

Hope this helps

Sincerely

PS thank you for v2! 🥰

ldexterldesign commented 2 years ago

👋

I think this issue should be reopened 🤔

After clicking extension icon/button it still takes ages for it to open (i.e. sometimes 10 or 20 seconds)

It doesn't appear to be CPU related judging from task manager..?

Is anyone else experiencing this( on macOS/Vivaldi)?

Regards

ldexterldesign commented 2 years ago

@perry-mitchell 👋

Pretty sure this is the cause:

I've disabled the feature and popup is now more reliable to activate and much more responsive

I suggest this is the default setting unless performance can be improved. At least if new users enable the feature and see a UX hit they'll know to disable it again.

I wish I'd have known 1.5 years ago as it would have saved me so much time!

Hope this helps