buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
228 stars 42 forks source link

Fix login - transferwise.com #Bug #373

Closed ldexterldesign closed 3 years ago

ldexterldesign commented 3 years ago

Hey,

Hope you're well

Thanks for software and sterling updates

As title

Login is failing with Buttercup extension installed

With extension installed, before (i.e. form submission submit) and after (i.e. form submission submit with error) DOM diffs reveal an input type has (unexpectedly) changed (see screenshot, line 45) - could Buttercup be responsible for this?

Without the extension installed it's tricky to get an after diff as the form submission is successful so I can't be sure the input type change issue is Buttercup specific

Screen shot:

Screenshot 2020-09-07 at 23 37 22

Screen cast:: https://www.dropbox.com/s/9rin1lgvdbsrmlv/foo.webm?dl=0

If you're reading and:

If you have any issues (e.g. questions/queries) then happy to help

Keep up good work!

Hope this helps & to hear back

Sincerely

software - OS: Apple, macOS, 10.15.6 (19G2021) software - application: Vivaldi, 3.2.1967.47 (Stable channel) (64-bit) software - extension: Buttercup, 2.23.0

perry-mitchell commented 3 years ago

Buttercup doesn't change the input type, it simply attaches to it. This is the area of interest, and you can see that it simply sets a dataset value, not an attribute. It does modify padding but this is simply for aesthetics (when placing the button).

ldexterldesign commented 3 years ago

Thanks for reply

Forget whether I did before but just tested with Firefox and Brave and confirmed the same issue

Very weird, I can only think there's some script conflict between TW and BC, otherwise why would their login function with BC disabled?

I've already spent a bunch of time trying to diagnose this, unsuccessfully, but without a login I doubt you can help so we'll chalk this up to an unknown

Ironically the only reason I came to login was to delete my account!

Closed issue but feel free to reopen if you care

Sincerely

ldexterldesign commented 3 years ago

Also, TW error is a bit sh#tty (i.e. both technically and non-technically)!

ldexterldesign commented 3 years ago

Read through the module

Long shot but could the .stopPropagation be the conflict here?

Disclaimer: I only have a basic understanding of how propagation works

Sincerely