search

buttercup / buttercup-browser-extension

:earth_asia: Buttercup browser extension
https://buttercup.pw
MIT License
228 stars 42 forks source link

Update style on generate password popup #375

Closed alxwrd closed 3 years ago

alxwrd commented 3 years ago

This is a small change to the password generator popup to update the styles.

Noticeably, on smaller password input fields, setting the password length to a high value would cause the password to overflow the popup. This causes the slider to 'bounce' making it harder to select the desired length, as well as not looking very nice.

This removes display: flex; from the root element, and adds a bit more to the popup height so the buttons are within the popup.

Before Firefox After Firefox
Before Chrome After Chrome
alxwrd commented 3 years ago

Maybe addresses #280?

perry-mitchell commented 3 years ago

Amazing! This is great. Thanks a lot @alxwrd!

perry-mitchell commented 3 years ago

@alxwrd I had to revert the flex change due to it breaking the auto-complete dialog:

image