buttercup / buttercup-core

:tophat: The mighty NodeJS password vault
http://buttercup.pw/
MIT License
467 stars 57 forks source link

bug report: unable to empty trash #329

Closed georglauterbach closed 1 year ago

georglauterbach commented 1 year ago

Information about my System

Running on an M2 MacBook Air with macOS 13.2.1 (22D68) (code name: Ventura).

The *.bcup file is located in a private cloud that is shared between multiple devices (and also accessed via WebDAV).

What's the Problem?

I cannot empty the trash. Pressing the red cross will shortly remove all entries, then they re-appear after a second and then the vault is synchronized.

I am uncertain as to how I provide more debugging information here - please let me know which logs you need and how I can get them.

perry-mitchell commented 1 year ago

Can you kindly make a back up of your vault, and then convert it to Format B in the vault options? Does the issue still occur then?

georglauterbach commented 1 year ago

I tried that, but it did not resolve the issue.

I cannot delete individual entries in the trash too. Tried it on my Mac and also on a mobile device (v2.5.3). Very weird.

EDIT: Also happens on a Windows machine. Maybe my file is somehow corrupted?

EDIT2: Also happens with a completely new tresor. So my file does not seem to be corrupted..

georglauterbach commented 1 year ago

Any ideas?

georglauterbach commented 1 year ago

ping

Pemichka commented 1 year ago

Moin,

bei mir tritt exakt das gleiche Problem auf. (Windows 11 und Tresor mit Format B) Nach Drücken des roten Kreuz leert sich der Papierkorb scheinbar aber mit dem speichern erscheint der Inhalt sofort wieder.

perry-mitchell commented 1 year ago

Looking into this now.

EDIT: So this seems to be a fundamental flaw in both formats A and B, though I'm not sure when it was introduced. Sometime perhaps around the last larger refactoring. I think I've cracked it for format A, and I'll have another go at B tomorrow. Should have a fix out during the weekend latest.

perry-mitchell commented 1 year ago

Released under 7.2.0

georglauterbach commented 1 year ago

Thank you so much! I'll wait for this version of core to become available and test it 👍🏼

Pemichka commented 1 year ago

Vielen Dank, es funktioniert wieder. Der Papierkorb ist leer.