search

buttercup / buttercup-importer

:fishing_pole_and_fish: 3rd-party archive importer for Buttercup
https://buttercup.pw
MIT License
43 stars 13 forks source link

Bcup export->import should remain the same #60

Open ldexterldesign opened 3 years ago

ldexterldesign commented 3 years ago

Hi!

Thanks, as always, for software

I have a use case for you...

Tonight I wanted to update my vault password

It seems this is non-trivial

I presume I have to:

  1. export my old vault data
  2. create a new vault
  3. import my old vault data to new vault

... if correct then the most useful export/import method (i.e. Buttercup CSV) seems to export all old vault custom fields (i.e. from every entry) to each new entry in the new vault

For example:

Vault

Entry 1

entry1field1: entry1field1value1
entry1field2: entry1field2value2
entry1field3: entry1field3value3

Entry 2

entry2field1: entry2field1value1
entry2field2: entry2field2value2
entry2field3: entry2field3value3

CSV (export)

entry1field1, entry1field2, entry1field3, entry2field1, entry2field2, entry2field3
entry1field1value1, entry1field2value2, entry1field3value3,,,
,,,entry2field1value1, entry2field2value2, entry2field3value3

Is this expected behaviour?

I would expect, by default, if the entry has no field value then don't show the field..?

IMO the export/import feature is currently redundant/unusable as I wouldn't want tons of superfluous/empty fields in all my entries 😕

Hope this is useful and to hear back

Sincerely

PS if this is, indeed, a problem then I suppose it's higher priority than solving my original use case 🤪

tigrouind commented 3 years ago

I was going to report the same issue. After an import (using Buttercup csv format) it should give the same result than before export.

Sans titre

Above : before export Below : after import

As you can see on screenshot the entry type has been lost (Website => Login) and "Url" field is now considered as a custom field named "url". Furthermore, Buttercup should provide an easy way to change vault password.

perry-mitchell commented 3 years ago

The extra fields are present in the CSV as it's a matrix - there's not really a nicer way to render all specified fields in a matrix besides listing out all of the used property names along the X axis (columns). This is expected. It should result in the same structure upon import, so for that I'll move this issue to the importer so it can be dealt with.

perry-mitchell commented 3 years ago

The master password change is a missing feature - buttercup/buttercup-desktop#1046