Autofill extension crashes on iOS - v1.9

buttercup / buttercup-mobile

:iphone: React-Native mobile application for Buttercup

https://buttercup.pw

GNU General Public License v3.0

392 stars 70 forks source link

Autofill extension crashes on iOS - v1.9 #179

Closed perry-mitchell closed 4 years ago

perry-mitchell commented 5 years ago

The autofill extension crashes when opening it within the latest version. It arrived after the google drive integration was included. Repeated attempts to open it result in the same effect.

When in development the autofill app simply shows a white screen.

se1exin commented 5 years ago

@perry-mitchell Fix is ready in #181 (hopefully!)

perry-mitchell commented 5 years ago

Seems this is still an issue. Reproducible both on an iPhone and in the simulator.

se1exin commented 5 years ago

Weird, I'm unable to reproduce the issue on the rn-59 branch. I did have to pretty much set the entire buttercup iOS dev environment up from scratch again due to all the stupid cache issues react-native has when anything changes in node_modules - so perhaps you are getting issues somewhere there?

Can you please retest the changes from #181 with a clean setup (RN cache clean, XCode clean, delete and reinstall pods, etc) and let me know how it goes?

perry-mitchell commented 4 years ago

Will do! I’ll have a go at that this evening 👍

perry-mitchell commented 4 years ago

Seems to work locally with the latest updates, will try to publish this one today.

perry-mitchell commented 4 years ago

Released under 1.10.1 on iOS. Can re-open if the issue persists.

perry-mitchell commented 4 years ago

@se1exin Thanks a bunch for checking in on this!