buttercup / buttercup-mobile

:iphone: React-Native mobile application for Buttercup
https://buttercup.pw
GNU General Public License v3.0
392 stars 70 forks source link

Unlock My buttercup archive failed: UUID generation failure #254

Open pleswi opened 3 years ago

pleswi commented 3 years ago

Android 10 or 11 Xiaomi Mi A2 lite or Pixel 5 Lates version of Buttercup from Play store

I succesfully added archive from My buttercup. (Authenticate and connect from MB in app). After that I try unlock new added archive and after few seconds of unlocking it fails with option "use offline", but that didn't work too. The error state is -> No pre-generated UUIDs available.

perry-mitchell commented 3 years ago

Sounds like a bug - Unfortunately the bcup library uses synchronous UUID generation for everything.. But it's not possible to synchronously generate cryptographically secure UUIDs on react-native, as far as I know. We have a hack in there to pre-generate some, but it seems like you've hit some kind of race condition that causes this error.

m8522s commented 3 years ago

I have the same issue. I noticed that this error is reproducible when the Buttercup archive is larger than a couple of entries (sorry, I don't have the exact number). If I remove many entries, it is possible to open the archive in my iPhone. Hope that information helps.

danitt commented 3 years ago

@perry-mitchell @msarig shot in the dark here, but this 200 limit might line up with the # of entries that crashes the app if exceeded in a single vault:

https://github.com/buttercup/buttercup-mobile/blob/56573db7388e3c8f8ec15c007d7ca367608802ce/source/compat/crypto.js#L14

m8522s commented 3 years ago

@perry-mitchell @msarig shot in the dark here, but this 200 limit might line up with the # of entries that crashes the app if exceeded in a single vault:

https://github.com/buttercup/buttercup-mobile/blob/56573db7388e3c8f8ec15c007d7ca367608802ce/source/compat/crypto.js#L14

My current vault has 121 entries and suffers from this bug.

taumeister commented 2 years ago

Hi, i have the same hiere on my iphone12 on webdav ( no pregenerated uuids available ) what a pity, I was looking forward to finally having a good password manager.

It works on my windows box, on my kdeneon...but not on my iphone...muah.weep...so sad..