buttercup / buttercup-mobile

:iphone: React-Native mobile application for Buttercup
https://buttercup.pw
GNU General Public License v3.0
392 stars 69 forks source link

[iOS] Autofill not working - Error thrown while trying to unlock Buttercup vault #298

Closed casasfernando closed 2 years ago

casasfernando commented 2 years ago

While trying to use Autofill, I'm getting an error when trying to unlock my vault. I have biometric unlock enabled, but it doesn't work. Unlocking the vault using password doesn't work either. I get the following error:

image

Steps to reproduce:

  1. Open Firefox
  2. Go to github.com and select sign in
  3. Select the user field in the form and iOS will present the option to choose from Passwords
  4. Tap on Passwords
  5. From the application list select Buttercup
  6. Tap on the vault to try to unlock it

Expected result: Buttercup vault is unlocked either by using biometrics or password. The username and password is automatically filled-in in the login form. Current result: Buttercup displays the error in the screenshot above and the vault is not unlocked.

I tried to disable and re-enable autofill for Buttercup from iOS settings but it didn't help.

Unlocking the vault from Buttercup app works with biometrics and password without any issues. This problem is specific to autofill feature in iOS.

iOS version: 15.2.1 Buttercup version: 2.1.0 Buttercup vault storage: webdav

Let me know if I should provide any other information. Thanks.

casasfernando commented 2 years ago

Updated to app version 2.2.0 and tested again. The issue is still present in this version.

perry-mitchell commented 2 years ago

Just tested those exact steps on 2.2.0 and it worked fine. I’ll try to dig into where that object.values call could be getting used. In the meantime I’d suggest trying to remove your vault and re add it.. or by simple disabling autofill and re-enabling it in the vault settings.

casasfernando commented 2 years ago

Thanks for looking into this but it’s working now. Based on your suggestion I checked the settings of the vault and autofill was disabled there (strange thing is that I don’t remember disabling it). Anyway, I enable it again and it’s working now.

Thanks again!