search

buttercup / buttercup-mobile

:iphone: React-Native mobile application for Buttercup
https://buttercup.pw
GNU General Public License v3.0
391 stars 69 forks source link

Can't add new entry #344

Closed Mxctr1 closed 7 months ago

Mxctr1 commented 7 months ago

Once you add a new Vault, you cannot add an entry. as soon as you try, the screen becomes unresponsive. you can only swipe back and when you swipe back the app crash...

Steps to reproduce

perry-mitchell commented 7 months ago

Thanks, I can reproduce. I'll try to fix it this evening. Apologies for the inconvenience.

perry-mitchell commented 7 months ago

So this seems to be something more systemic, perhaps with UIKitten:

2023-12-04 21:41:30.819205+0200 Buttercup[46034:1895237] [Presentation] Attempt to present <RCTModalHostViewController: 0x7f9a657162d0> on <UIViewController: 0x7f9b24d08550> (from <RNSScreen: 0x7f9a65662950>) which is already presenting <RCTModalHostViewController: 0x7f9ac5132d90>.

The root one always shows (password for vault), but the nested ones, after this release, no longer do. Not sure what's causing it to be honest.

There are other issues on the UIKitten repo referencing a crash when switching tabs: https://github.com/akveo/react-native-ui-kitten/pull/1790 - but I don't think this is entirely related.

perry-mitchell commented 7 months ago

Tried downgrading UI kitten, and then upgrading React-native to the latest. No dice. It's some other internal library 😞

perry-mitchell commented 7 months ago

I might have found a way around the issue.. using timeouts. It's ugly but there seems to be no other way for now. I've filed a bug here on the UI kitten repo: https://github.com/akveo/react-native-ui-kitten/issues/1798

I'll try to release a patch today/tomorrow.

perry-mitchell commented 7 months ago

Released a fix in 2.6.1.

Mxctr1 commented 6 months ago

Seems like the problem is when you try to save the application just crash