search

buttercup / buttercup-mobile

:iphone: React-Native mobile application for Buttercup
https://buttercup.pw
GNU General Public License v3.0
401 stars 71 forks source link

Removed storage requests for Android 10+ when enabling autofill #383

Closed CopticFelo closed 2 months ago

CopticFelo commented 4 months ago

This PR fixes #356

Why is this needed

The READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE were replaced with Mediastore permissions in Android 10 (API level 29) and were completely deprecated in Android 13 (API level 33), so trying to request these permissions on Android 13 or higher will just result in the "Permissions not granted" error, See Scoped Storage and Breaking changes in Android 13

What this adds

I just added an additional check when enabling autofill to not try to request Storage permissions when Android version is 10 or higher (API level 29 or higher)

lomignet commented 2 months ago

@perry-mitchell Once this one is merged, happy to validate if #356 is fixed.