Open perry-mitchell opened 5 years ago
@sallar @perry-mitchell Can I work on remaining list of this issue ?
@zoheirkhonyagar Sure, why not? :)
@sallar Thank you :)
I've picked up the Rename-group feature myself, FYI.
@sallar @perry-mitchell Where is the empty trash button position in the component ? I suggest when user right click on Trash button, open a menu and show "Empty Trash" option something like this image that I've attached.
I see it now that @perry-mitchell is working on this issue in groups_menu branch . if there are tasks that you didn't start working on, I can do them :)
@zoheirkhonyagar Ive decided that I won’t attempt to do the empty trash etc in this branch as that’s big enough on its own.
We need to display a tree of contents for the trash as it also holds groups, not just entries. Maybe, as @sallar suggested to me, it could be clicked which would slide up and reveal the trash tree instead of the regular one. There’s a helper function called emptyTrash
in the useGroups
hook.
@perry-mitchell Thank you for your explanation,I got that . so can I work on empty trash now ?
so I've picked up the Empty trash feature, FYI.
@perry-mitchell Hey, I tried to understand project structure but it's hard for me because I'm new in React, I define onEmptyTrash
function in EntriesList.js
and then add onClick event to PaneContent
, In onEmptyTrash
I call emptyTrash
helper that you mentioned. but when it calls pane title changes to Document. I'm confused :smile: