Final upgrades to editing UI

[perry-mitchell]

• [x] New group
• [x] Delete group
• [x] Rename group
• [x] Move group
• [ ] Empty trash
• [ ] Fix trash count (all entries and groups)
• [ ] Show groups in trash

[zoheirkhonyagar]

@sallar @perry-mitchell Can I work on remaining list of this issue ?

[sallar]

@zoheirkhonyagar Sure, why not? :)

[zoheirkhonyagar]

@sallar Thank you :)

[perry-mitchell]

I've picked up the Rename-group feature myself, FYI.

[zoheirkhonyagar]

@sallar @perry-mitchell Where is the empty trash button position in the component ? I suggest when user right click on Trash button, open a menu and show "Empty Trash" option something like this image that I've attached.

[zoheirkhonyagar]

I see it now that @perry-mitchell is working on this issue in groups_menu branch . if there are tasks that you didn't start working on, I can do them :)

[perry-mitchell]

@zoheirkhonyagar Ive decided that I won’t attempt to do the empty trash etc in this branch as that’s big enough on its own.

We need to display a tree of contents for the trash as it also holds groups, not just entries. Maybe, as @sallar suggested to me, it could be clicked which would slide up and reveal the trash tree instead of the regular one. There’s a helper function called emptyTrash in the useGroups hook.

[zoheirkhonyagar]

@perry-mitchell Thank you for your explanation,I got that . so can I work on empty trash now ?

[zoheirkhonyagar]

so I've picked up the Empty trash feature, FYI.

[zoheirkhonyagar]

@perry-mitchell Hey, I tried to understand project structure but it's hard for me because I'm new in React, I define onEmptyTrash function in EntriesList.js and then add onClick event to PaneContent, In onEmptyTrash I call emptyTrash helper that you mentioned. but when it calls pane title changes to Document. I'm confused :smile: