Closed etodanik closed 6 years ago
Provider API is not final yet so braking changes are not an issue.
Name should probably be combination of provider name and sorter name. So for "Top Movies" should be "defaultSorter.name provider.name".
For "More Movies" we should probably hardcore more part.
This should probably be part of TVOverviewPresenterImpl since it is only used there.
This was fixed and merged into develop.
Right now there are hardcoded "More Movies" and "Top Movies" strings in the overview navigation. It would make more sense to derive that from the Provider, similar to
getDisplayName()
that exists right now onProviderWrapper
.I'm willing to submit a PR, but first I'd like to know which approach to take, since the change will affect all provider implementations.
My suggestion is to add methods on the wrapper that would return the appropriate labels for Top/More e.t.c necessary in navigation. Any thoughts?