search

butterproject / butter-desktop-angular

Angular version of butter-desktop
Other
97 stars 43 forks source link

{filter-bar, device-selector} work #7

Closed hadim closed 8 years ago

hadim commented 8 years ago
hadim commented 8 years ago

I also remove .png device icons files and replace them by svg version (for now the svg file contains only the original png file... it would be nice to correctly vectorize icons one day).

hadim commented 8 years ago

@BoLaMN Comments ?

BoLaMN commented 8 years ago

With the svg icons bring them in thru $mdIconProvider for easier reuse https://material.angularjs.org/latest/api/service/$mdIconProvider

hadim commented 8 years ago

Ok I will do that but can we merge this before ? So I can open a new PR.

hadim commented 8 years ago

This one is going to be too big at one moment !

BoLaMN commented 8 years ago

Small still ;)

I have no say over PRs as I'm not actually an active dev on this lol. I'm just offering suggestions and hints as I wrote most of the current angular version for fun in my spare time so I kinda have an idea how it all works.

I'll probably continue building the webchimera player as I ripped most of that out in to a seperate module to make it easier to work on the player.

hadim commented 8 years ago

Ok thank you for that @BoLaMN. I may ping you sometime to get suggestions from you.

To be sure, I'd like to know if im not working for nothing here. Is angular and this repo going to be the main butter app one day (even if we are far from this) or is this just a proff of concept no one care ?

Once you have a player working @BoLaMN , merge it asap here so we can move forward !

BoLaMN commented 8 years ago

Sure happy to offer suggestions.

The newer player module lives at https://github.com/BoLaMN/wcjs-angular and basically 95% of the webchimera folder could be removed in place of it if you use it.

hadim commented 8 years ago

Ok so do you suggest that wcjs-angular would live as a separate project and we just get it in butter with npm or are you planning to merge it here at one moment ?

BoLaMN commented 8 years ago

I'd suggest a seperate module as it makes working on either project easier. the player module is pretty universal and allows you to extend via your own plugins for what ever butters needs are.

hadim commented 8 years ago

Sounds good to me ! Feel free to submit PR here to include wcjs-angular as a dependency and the player.

What about the streamer ? Is it working ?

BoLaMN commented 8 years ago

The streamers all in the server folder.

my end goal was to decouple the browser rendering from the node processes to not block the ui but yes it was working previously.