butterscotchstallion / limnoria-plugins

A smattering of Limnoria plugins I've written
MIT License
14 stars 14 forks source link

Changed BeautifulSoup parser to html5lib #99

Closed Znuff closed 7 years ago

Znuff commented 7 years ago

This makes it possible for SpiffyTitles to decode html entities like ă â , etc.

butterscotchstallion commented 7 years ago

What are the implications of this? Does it break stuff?

Znuff commented 7 years ago

So far for me it didn't break stuff.

The old parser was breaking on titles that contain HTML entities - it never decoded all of them because they weren't, technically valid HTML entities before HTML5 came, like ă and so on

butterscotchstallion commented 7 years ago

Oh, nice! Thanks for contributing!