search

buttilda / Gany-s-Surface

Gany's Surface
8 stars 10 forks source link

Can't access vanilla crafting table #59

Closed Adaptivity closed 9 years ago

Adaptivity commented 9 years ago

This happens to me since the first version with "no recipe conflict mode". I just can't access vanilla crafting table. I thought that No recipe conflict mod messed up it because I forgot to remove it when updated Gany's Surface. But no, still can't access it. Disabling "No Recipe Conflict for Crafting Tables" fixes the problem. I can provide modpack if needed. Mods installed: http://i.imgur.com/pexi5ug.jpg Forge 1481 Config: In config I've disabled 1.8 stones and doors since those added by another mod.

buttilda commented 9 years ago

Very strange... no idea what could be going one there. Do any of those mods you're using mess with the crafting table in any way?

Adaptivity commented 9 years ago

As far as I know, no. The only mod which interacted with vanilla crafting table is No more recipe conflict but it's got removed. I've uploaded a .zip archive with mods and config folders. Maybe you'll find a culprit.

buttilda commented 9 years ago

Thank you, downloaded it. I'll test it later :3

Dulciphi commented 9 years ago

Hello again. I'm not sure if this can help you in any way with this issue, but I've just crashed when accessing the vanilla crafting table myself. If this seems like another issue, let me know please? http://pastebin.com/cyV40kN5

Thanks

Edit for update- just to confirm, the crash happened when attempting to access a vanilla crafting table. I did have NoMoreRecipeConflicts installed with the first crash. I also had the config for your NoMoreRecipeConflicts set to true (derp). The first thing I tried was disabling your worktables. That didn't help. Same crash. After reading more about it on the MCF thread, I realised my derp and tried uninstalling the NoMoreRecipeConflicts mod. Same crash.

So, finally, I re-enabled your worktables and set your NoMoreRecipeConflicts setting to "False", then reinstalled the NoMoreRecipeConflicts mod. Now I'm not crashing. I'm able to access the vanilla crafting table and use Ganys Surface-1.12.2

Sorry I've not been able to nail down the exact cause of the issue, but at least I still get to use your mod and the vanilla crafting table

buttilda commented 9 years ago

It's caused by CustomNPCs, it modifies the crafting recipes list every game tick (no idea why...) which causes the crash. Unfirtunatelly there's nothing I can do about it. The only way to avoid the crash is by turning the feature off or removing CustomNPCs

Edit: Actually, after looking properly into it, CustomNPCs doesn't alter the crafting recipes every tick, it only feels the need to sync it with the client every time the player opens the crafting table GUI. But that's just details. The problem persists. Either they handle their recipe syncing properly, or the feature will remain incompatible.

Dulciphi commented 9 years ago

Ahhh thank you for that info. In that case.. does your NoMoreRecipeConflict setting work in Tinker's workbenches? The NoMoreRecipeConflict mod doesn't and I'm just trying to weigh up pros and cons until (hopefully) the customNPCs issue is fixed

buttilda commented 9 years ago

It doesn't, but I heard boni is re-writing TiCon's crafting tables, maybe you should ask him to support it (he'd have to implement it himself, but my mod is open source, so he'd be more than welcome to see how I did it)

As for the issue with CustomNPCs being resolved... I can't fix it, they are the ones that will have to do it. Although I tried to reproduce the issue on my end and was unable to. So it might even be a third mod causing CustomNPCs to break Gany's Surface... I re-wrote some parts of the system recently (so that the buttons only show up if there is actually a conflict. Makes the GUI cleaner), so who knows.. maybe the issue fixed itself =P

Adaptivity commented 9 years ago

Seems to be fixed.