search

buttilda / Headcrumbs

Headcrumbs
aww yiss
14 stars 21 forks source link

Celebrities are spawning in mushroom island biomes #27

Closed ephys closed 9 years ago

ephys commented 9 years ago

Mushroom island (and island shore) biomes are peaceful biomes, however the celebrities which are somewhat aggressive mobs are spawning there. And as they're the only mobs allowed to spawn there, they're spawning massively (even with the probability set to 1).

Would you be so kind as to blacklist them from that biome ? Thank you ~

buttilda commented 9 years ago

That's weird. I coded it specifically so it wouldn't spawn in mushroom islands/shores. Are you using a biomes mod?

ephys commented 9 years ago

Biomes o' plenty but I don't think it overwrites the mushroom island

Edit: I think I know why, this algorithm [https://github.com/ganymedes01/Headcrumbs/blob/b3682b18443c41717079c384813dddc0379a40c5/src/main/java/ganymedes01/headcrumbs/Headcrumbs.java#l170] would work if biomes couldn't have more than one type. The correct way to do it would be to get a list of every biomes and then get the types of each biome and check if one of these types is in the blacklist :3 (okay that's not very clear, what I tried to say is that the mushroom island isn't just stored in the Mushroom type list)

buttilda commented 9 years ago

Makes sense!

buttilda commented 9 years ago

Changed it around, mind having a look at it now and telling me what you think?

ephys commented 9 years ago

I believe that should work, if you've got a jenkins I can go test that in my world and confirm it :)

buttilda commented 9 years ago

https://dl.dropboxusercontent.com/u/213747910/Headcrumbs-1.3.2.jar

Backup your save before using this btw :3

ephys commented 9 years ago

It resulted in a NPE when I tried to launch Minecraft: http://pastebin.com/ExHCWhF2

Took a look at the source code of BiomeDictionnary, it's the biome passed to getTypesForBiome that is null as BiomeGenBase.getBiomeGenArray() is a stupid array and not a list ^^'.

buttilda commented 9 years ago

of course... silly me

Try re-downloading it (same link)

ephys commented 9 years ago

It's fixed, thank you :)

buttilda commented 9 years ago

Awesome! You can use that version, it should be pretty stable. I did some re-writing of some core features (just to make them neater and easier to expand on), added heads of hermitcraft members and Primitive Mobs heads.