search

buttleofx / ButtleOFX

ButtleOFX is an open source compositing software.
http://buttleofx.wordpress.com
91 stars 22 forks source link

Added margins to UI #111

Closed JamesWrigley closed 10 years ago

JamesWrigley commented 10 years ago

Hi there, I made a few small changes to add margins to some buttons at the ends of the file browser header + footer, and also to center the filenames in the context menus. I also added a few more patterns in .gitignore for Emacs.

fabiencastan commented 10 years ago

Hi, Thanks for the pull request. I'm currently in holidays, but I will check and merge it in 1 week.

JamesWrigley commented 10 years ago

Righto, thanks :)

JamesWrigley commented 10 years ago

Update: Another minor change to center the filenames in listview mode.

fabiencastan commented 10 years ago

Mostly merged by without using anchors.

We try to avoid using anchors for positionning because it conflicts with Layouts. It's fine to use "anchors.margins", "anchors.fill", etc. but not for positionning like "anchors.right: parent.right" as we could do the same with RowLayout.

Please notify me if I missed something in your pull request. I have tried to achieve the same result.

JamesWrigley commented 10 years ago

Ah I see, will keep that in mind. One minor note though, the filenames in the list view aren't centered vertically.