buttleofx / ButtleOFX

ButtleOFX is an open source compositing software.
http://buttleofx.wordpress.com
91 stars 22 forks source link

Tuttle error: on file without extension #148

Closed aoblet closed 9 years ago

aoblet commented 9 years ago

/home/fab/dev/TuttleOFX/libraries/tuttle/src/tuttle/host/io.cpp(92): Throw in function std::string tuttle::host::io::getFileExtension(const string&) Dynamic exception type: boost::exception_detail::clone_impltuttle::exception::File kOfxStatFailed[tuttle::exception::tagdevMessage] = Filename has no extension "final". [tuttle::exception::taguserMessage] = Filename has no extension "final". [tuttle::exception::tagbacktraceMessage] = [boost::errinfo_file_name__] = final

stop pysequenceParser::browse() process See it with #139, or correct it with tuttle cpp or both?

cchampet commented 9 years ago

The problem is not in sequenceParser, which supports filename with no extension. The problem is in tuttle: https://github.com/tuttleofx/TuttleOFX/blob/buttle3_upSequenceParserRemoveSam/libraries/tuttle/src/tuttle/host/io.cpp#L90

Don't you want to catch an exception when try to create a thumbnail from a file with no extension ?

fabiencastan commented 9 years ago

@aoblet There is no link with the sequenceParser. It's during the thumbnail creation: https://github.com/buttleofx/ButtleOFX/blob/f62bf047d2e57868ea10e5532f022cbda0ce5825/buttleofx/main.py#L197

But it's just a warning, there should be no problem.

aoblet commented 9 years ago

Actually it was crashing into browserItem by: bool(tuttle.getReaders) with a file without extension. I handled it. It's okay.

fabiencastan commented 9 years ago

crash != exception

aoblet commented 9 years ago

Yes sorry. I didn't catch the exception before.