button-inc / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.
Apache License 2.0
0 stars 0 forks source link

fix: remove failing npm audit and fix duplication #11

Closed BCerki closed 2 years ago

BCerki commented 2 years ago

Implement Alec's feedback from this review: https://github.com/bcgov/digital_marketplace/pull/177 (fix CI running twice and remove npm audit)

The goal is to keep the main branch green

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mikevespi commented 2 years ago

Related issue: https://github.com/button-inc/digital_marketplace/issues/10

wenzowski commented 2 years ago

Per our call, @BCerki will merge this (very first merge so no need to post in chat before doing so, but it never hurts to exercise the muscle)