Closed BCerki closed 2 years ago
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
16.4% Duplication
I completely agree and if that's the only reason this is failing the Quality Gate then it's a good thing that's not a required status check–we'll exercise our code review discretion and ignore the duplication as it's a pre-existing issue, this PR does not represent a regression, and this PR improves the overall quality of the target branch by removing tsconfig duplication.
These changes standardize the front-import paths so "front-end" always stands in for "front-end/typescript." This means no 1,000 changes to front-end file import paths.
The two testing index.js
files grab paths from the tsconfig, which is why I couldn't delete the paths there (this may also be why I was getting errors about having comments). I was able to get the front-end testing index.js
to grab the paths from the root tsconfig. The back-end testing index.js
still grabs the paths from the back-end testing tsconfig because when I tried to get them from the root one, I started getting path errors for the files the tests imported, not sure why.
This PR:
A few things I'd love feedback on:
npm run front-end:watch
,npm run back-end:watch
,npm run front-test
,npm run back-end:test
,npm run migrations:latest
to confirm the changes hadn't caused compilation errors. I think the front-/back-end scripts would have covered my changes to theshared
tsconfig, but I'm not sure about thescripts
onetsconfig
s, so we left them in for now (late-breaking thought--I think the issue is related to using mocha (the paths are imported from thetsconfig
into'index.js
), so once we've switched to jest, it won't be an issue)