button-inc / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.
Apache License 2.0
0 stars 0 forks source link

Dm 5 tsconfig #17

Closed BCerki closed 2 years ago

BCerki commented 2 years ago

This PR:

A few things I'd love feedback on:

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.4% 16.4% Duplication

wenzowski commented 2 years ago

I completely agree and if that's the only reason this is failing the Quality Gate then it's a good thing that's not a required status check–we'll exercise our code review discretion and ignore the duplication as it's a pre-existing issue, this PR does not represent a regression, and this PR improves the overall quality of the target branch by removing tsconfig duplication.

BCerki commented 2 years ago

These changes standardize the front-import paths so "front-end" always stands in for "front-end/typescript." This means no 1,000 changes to front-end file import paths.

The two testing index.js files grab paths from the tsconfig, which is why I couldn't delete the paths there (this may also be why I was getting errors about having comments). I was able to get the front-end testing index.js to grab the paths from the root tsconfig. The back-end testing index.js still grabs the paths from the back-end testing tsconfig because when I tried to get them from the root one, I started getting path errors for the files the tests imported, not sure why.