search

button-inc / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.
Apache License 2.0
0 stars 0 forks source link

Follow up improvements to documentation of branching model #21

Closed kriscooke closed 2 years ago

kriscooke commented 2 years ago

Follow up on some typos and elaboration as discussed in this review.

kriscooke commented 2 years ago

Along with the typo suggestions above, [issue#]-brief description may be more clear to indicate replacement, or show an example, to not be confused with prefixing with "issue":

Like this: 8-update-sass Not this: ~issue#8-update-sass~

wenzowski commented 2 years ago

In addition to the above referenced thread on #18 (thanks @kriscooke) perhaps this discussion should include discussion of what behaviours conventions provoke? Adopting a branch naming convention that begins with the ticket number strongly encourages the team to always make an issue before making a branch/PR. Is this always necessary in our new workflow?

BCerki commented 2 years ago

Would also like to discuss requesting a particular reviewer vs. marking as ready for review, especially days when Mike isn't here

wenzowski commented 2 years ago

I'd lean towards creating a @button-inc/digital_marketplace team on GitHub and making the entire Button development team the CODEOWNERS of this entire fork. That doesn't solve for everything

especially days when Mike isn't here

but it would ensure the act of requesting review is automated by a guardrail.

mikevespi commented 2 years ago

@wenzowski do we have a team in github already that includes all of our devs? When I try to search for button-inc in the settings to give permissions, nothing comes up

BCerki commented 2 years ago

Changes to branching agreement are merged in. Since we're moving back to the bcgov repo, fork codeowners is no longer relevant.