Remove lint CI job? - Githubissues

button-inc / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.

Apache License 2.0

0 stars 0 forks source link

Remove lint CI job? #68

Closed BCerki closed 2 years ago

BCerki commented 2 years ago

One of the CI jobs is to run the project's linting scripts:

"back-end:lint": "npx tslint -c tslint.json src/back-end/*.ts src/back-end/**/*.ts && echo Lint Successful\n"
"front-end:lint": "npx tslint -c tslint.json src/front-end/*.ts src/front-end/**/*.ts && echo Lint Successful\n"

Is this duplicating what pre-commit/eslint is doing?

As a developer I want to avoid duplication in my CI jobs because I want CI to run faster

BCerki commented 2 years ago

I rescind this question--lint caught stuff pre-commit/eslint didn't: https://github.com/button-inc/digital_marketplace/runs/4780640018?check_suite_focus=true