search

button-inc / service-development-toolkit

Toolkit for button applications
Apache License 2.0
5 stars 3 forks source link

BCGov Alert component enhancement #339

Open junminahn opened 3 years ago

junminahn commented 3 years ago

Is your feature request related to a problem? Please describe.

I would like to enhance the BC Gov theme's Alert component to:

  1. Align the left icon to the top vertically.
  2. Prop to change the close button to something else rather than close

From Junmin: for #1. if the content is more than one line, then the second line starts just below the icon that make it look ugly. like 1

for #2, there is a button close on top right, but I want to show different text or icon to delegate the action. like 1

zoeyli-46 commented 2 years ago

image.png Suggested improvements:

  1. icon is top left aligned when alert is multi-line
  2. text can be customizable depending on use case, one possibility for text could just be dismiss

https://www.figma.com/file/w363z7mQ2MRNQdkPeeZIkm/Button-Design-Library?node-id=419%3A264

zoeyli-46 commented 2 years ago

image.png

Suggested addition: Snackbar with x icon, snackbars appear in bottom left of screens, they are not as visible or "intrusive" as an alert, a snackbar may be used when whether the user sees the snackbar doesn't impact the user's next actions

junminahn commented 2 years ago

@zoeyli-46 thank you for the designs; I believe we can re-design the default close section; but as people have different views, it will be great to have an option to replace the section depending on the use case. I see this issue is more like functional enhancement rather than design improvement. thanks!

zoeyli-46 commented 2 years ago

@junminahn thank you for explaining! Who or which team can make this improvement in the toolkit and then close this issue?