search

button-inc / service-development-toolkit

Toolkit for button applications
Apache License 2.0
5 stars 3 forks source link

BCGov Navigation right panel #340

Open junminahn opened 3 years ago

junminahn commented 3 years ago

Is your feature request related to a problem? Please describe.

I would like to have a way to pass a prop for the right side of the navigation.

Describe the solution you'd suggest

here is an alternative we did to make it work

matthieu-foucault commented 3 years ago

Related: it might be good to be able to add buttons in the Header and in the top of the Navigation component, with the main use case being the login/out button. I am now wondering if that should be where those actions go (i.e. same as what we implemented for the CIIP app), or if they should be in the navigation bar. I don't see any login button in the BC design system...

kriscooke commented 3 years ago

👍 Thanks @matthieu-foucault, providing auth actions and status is a very real need that's not clearly addressed.

kriscooke commented 3 years ago

@junminahn From looking at your example, it appears the main problem you needed this to solve was the ability to display login/logout actions based on the user's current authentication?

I sense two ideas being proposed here, and am curious to explore the need priority for each:

  1. Login/out status and actions: An action that's typically presented in and around header navigation.
  2. Potential desire to extend the Header in other ways (unrelated to navigation)?

Since it's not clear where else one could easily provide auth status/actions, (1) certainly seems to be a blocking level of priority for the many products employing authentication.

If you think there's a potential need for (2) beyond auth, I'm curious to know what might be the specific imagined use cases?