search

buttondown / roadmap

Buttondown's public roadmap
48 stars 0 forks source link

reuse-and-edit no longer auto-updates the url-slug #3012

Open james-baker opened 2 days ago

james-baker commented 2 days ago

I'm pretty sure this changed fairly recently, as I didn't used to have this problem and my workflow hasn't changed.

Repro: Start a new email via "Reuse" on the most recent published email. Edit the title of the newsletter to something new/different. Write the newsletter body blah blah. Click on "Web Archive" button.

Expected: slug has been generated reflecting the new title Actual: slug has old title plus a numeric uniquifier added

Downstream conditional expectation, if I delete the slug (any customized or existing slug): Expected: it should generate a new slug for me same as if I had just written a newsletter from scratch Actual: nope, that didn't happen, and the URL came out as the super long ugly GUID string

I know there's some logic like "if the slug is custom-edited, stop auto-updating it" so maybe something in there got lost in the Reuse case?

jmduke commented 2 days ago

@james-baker

Mind sharing IDs for both of these?

(Your mental model is correct, btw — but the reuse flow doesn't copy over the slug, so imagine there's something weird happening.)

james-baker commented 1 day ago

@jmduke I believe it was 3ec8817c-b0f2-4d51-8acf-e56fb8e11b98 which reused from be881dcc-f2a5-474d-911e-1eb347077b81