search

buttondown / roadmap

Buttondown's public roadmap
51 stars 0 forks source link

Move dropdowns over to Radix Vue #3171

Closed mary-ext closed 4 days ago

mary-ext commented 1 month ago

We've decided on using Radix Vue after some evaluations from https://github.com/buttondown/roadmap/issues/2983. While we could tackle nested dropdowns now, we're still unsure about how exactly that should work and look in conjunction with the drawer stuff that we need for mobile UI, so let's defer that for now.

Dropdown Menu docs Drawer thing for mobile

mary-ext commented 1 month ago

This might be a bit painful to pull off since our dropdown menus are rendered by Dropdown.Container and the actual menu items by List.MenuItem, we might need to untangle it potentially? (moving List.MenuItem to Dropdown.Item, which is a lot more clear.) I think we're better off doing that anyway.

jmduke commented 1 month ago

moving List.MenuItem to Dropdown.Item, which is a lot more clear.) I think we're better off doing that anyway

yeah this might be a good Step 1. From my cursory inspection there are no MenuItems that aren't contained in a Dropdown anyway, so I suspect it's just carryover from back when the design system was a little more lawless