search

buttondown / roadmap

Buttondown's public roadmap
51 stars 0 forks source link

Subscription state should be taken from newsletter, not from account? #3222

Open catdevnull opened 1 month ago

catdevnull commented 1 month ago

image

confusingly shows up as features that requires an upgrade. Should show the proper feature status instead (left: team member account. right: newsletter owner account)

only happens in gift subscription accounts

catdevnull commented 1 month ago

This seems harder than what I can handle at the moment

jmduke commented 1 month ago

Yeah, the logic here is a little convoluted (check out DECISION-5 in Notion for more) at first glance. I think all we need to do is also serialize and pull in owning_account_billing_type like we do for owning_account_billing_plan, but I don't think this is super urgent.

catdevnull commented 1 month ago

Okay, do assign this to me whenever you think it should be done then. I just didn't want to touch too much billing code that I didn't know much about, but your solution seems easy and makes sense