Open cgolubi1 opened 10 years ago
In the normal course of events, players should never see is_action_current() failures. But that means that people who see them are always in a situation where the failures are unexpected and need to be debugged, whether that's (a) a player using the normal UI whose page is stale and doesn't realise it, (b) someone writing their own API client who hasn't sorted the timestamp business yet, or (c) a dev trying to debug a problem. In each of those cases, i think it's more useful to know what actually went wrong.
At the moment, if is_action_current() fails, there's not a very good corellation between why is_action_current() reported a failure, and what gets told to the player via the API. For instance, if i try to submit die values as a player who's not in a game, i get back "Dice sizes no longer need to be set".
I have two suggestions to improve this: