buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

Allow markup in other places #1518

Open yawetag opened 9 years ago

yawetag commented 9 years ago

Markup in the forums is great. Can we extend it to create_game and even the chat for games?

yawetag commented 9 years ago

Also, allow new lines in create_game

cgolubi1 commented 8 years ago

Hmm? You can already use the forum markup within game chat. What's in this issue which is actually unimplemented?

dwvanstone commented 8 years ago

I verified forum markup works in game chat. I verified it does not work in game description text when creating a game.

irilyth commented 8 years ago

Huh, evidently. I never realized this; there's nothing that indicates that it works there. Is the "Available markup" box from the forums too unwieldy to put on the game pages next to the chat box?

dwvanstone commented 8 years ago

Looking at the code, I think but forum markup is accidentally being applied to the game chat.

I am looking into this area of the code (for bug #1684) and may end up turning off this "feature" in the game chat.

Do we want to have the game chat include "forum markups"?

dwvanstone commented 8 years ago

By the way, it is also applied to the comment in one's profile text, but I think it needn't be.

cgolubi1 commented 8 years ago

I don't think this is an accident. I think we want to use the same markup in all text boxes. Why turn it off? Let me try to turn up the issues in which we originally discussed this for some evidence that it was intentional.

cgolubi1 commented 8 years ago

So, #1079 is where we turned on markup parsing in the comment field of the profile.

cgolubi1 commented 8 years ago

Also, there's an open issue, #1026, for describing the markup legend in game chat.

dwvanstone commented 8 years ago

I stand corrected! Okay, I'll make sure the function called makes it clear that the markup is being applied. (There are some cases where the markup isn't desired, such as in a forum title.)

cgolubi1 commented 8 years ago

Sounds good, thanks.